Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 test: add go/v3-alpha e2e tests #1756

Merged
merged 1 commit into from
Nov 10, 2020
Merged

🌱 test: add go/v3-alpha e2e tests #1756

merged 1 commit into from
Nov 10, 2020

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Oct 29, 2020

This PR adds e2e tests for go/v3-alpha and refactors test code such that it is easier to add other plugin tests going forward.

  • test/e2e/utils: add util to remove tool binaries from path
  • test/e2e/v3: refactor generation code so all plugins can be tested
  • *: clean up scripts

Pulls refactoring/cleanup from #1644

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 29, 2020
@estroz
Copy link
Contributor Author

estroz commented Oct 29, 2020

/cc @camilamacedo86

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@estroz
Copy link
Contributor Author

estroz commented Oct 29, 2020

Relates to #1746.

@estroz
Copy link
Contributor Author

estroz commented Oct 30, 2020

Blocked by #1746

@christopherhein christopherhein mentioned this pull request Nov 5, 2020
Merged
@christopherhein
Copy link
Member

Blocked by #1746

In the interim can we use an alpha release like https://github.com/kubernetes-sigs/kubebuilder/pull/1790/files#diff-e33c8c9eef8145c9616af064f8df83cdc5a36371b5884f39e279fc1dc87535a7R40 I don't want to duplicate fixing up all the tests for 0.7.0 if I can help it. See https://github.com/kubernetes-sigs/kubebuilder/pull/1790/files#r518356945 for @Adirio and @camilamacedo86's feedback

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2020
@estroz
Copy link
Contributor Author

estroz commented Nov 8, 2020

@christopherhein agreed, but for tests to pass kubernetes-sigs/kubebuilder-declarative-pattern#127 needs to be merged first.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2020
@estroz estroz mentioned this pull request Nov 10, 2020
Merged
@estroz
Copy link
Contributor Author

estroz commented Nov 10, 2020

Closing, see #1787 (comment)

@estroz estroz closed this Nov 10, 2020
@estroz
Copy link
Contributor Author

estroz commented Nov 10, 2020

Reopening to add tests so reverted PR's can be re-submitted.

@estroz estroz reopened this Nov 10, 2020
@estroz
Copy link
Contributor Author

estroz commented Nov 10, 2020

Blocked by #1806, #1807

This was referenced Nov 10, 2020
Merged
Merged
@Adirio
Copy link
Contributor

Adirio commented Nov 10, 2020

Seems to be some issue with authorization required for leader election:

E1110 04:32:36.089670       1 leaderelection.go:325] error initially creating leader election record: leases.coordination.k8s.io is forbidden: User "system:serviceaccount:e2e-ewba-system:default" cannot create resource "leases" in API group "coordination.k8s.io" in the namespace "e2e-ewba-system"
E1110 04:32:39.545701       1 leaderelection.go:321] error retrieving resource lock e2e-ewba-system/a3b38f53.example.comewba: leases.coordination.k8s.io "a3b38f53.example.comewba" is forbidden: User "system:serviceaccount:e2e-ewba-system:default" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "e2e-ewba-system"

@estroz
Copy link
Contributor Author

estroz commented Nov 10, 2020

@Adirio fixed in #1809

@estroz
This commit adds e2e tests for go/v3-alpha and refactors
c4f88e2 
test code such that it is easier to add other plugin tests
going forward.

test/e2e/utils: add util to remove tool binaries from path

test/e2e/v3: refactor generation code so all plugins can be tested

test/e2e/v2: rename test files

*: clean up scripts
@Adirio Adirio mentioned this pull request Nov 10, 2020
Merged
@Adirio
Copy link
Contributor

Adirio commented Nov 10, 2020

Once #1809 (linked above) gets merged, this may need a rebase.

@Adirio
Copy link
Contributor

Adirio commented Nov 10, 2020

/test pull-kubebuilder-test
/test pull-kubebuilder-e2e-k8s-1-14-1
/test pull-kubebuilder-e2e-k8s-1-15-3
/test pull-kubebuilder-e2e-k8s-1-16-2
/test pull-kubebuilder-e2e-k8s-1-17-0
/test pull-kubebuilder-e2e-k8s-1-18-0

camilamacedo86
camilamacedo86 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0cebbd6 into kubernetes-sigs:master Nov 10, 2020
@estroz estroz deleted the feature/go-v3-alpha-e2e branch November 10, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@droot droot Awaiting requested review from droot

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@estroz @christopherhein @Adirio @k8s-ci-robot @camilamacedo86