-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test: add go/v3-alpha
e2e tests
#1756
🌱 test: add go/v3-alpha
e2e tests
#1756
Conversation
/cc @camilamacedo86 |
Relates to #1746. |
00e788c
to
8706317
Compare
Blocked by #1746 |
In the interim can we use an alpha release like https://github.com/kubernetes-sigs/kubebuilder/pull/1790/files#diff-e33c8c9eef8145c9616af064f8df83cdc5a36371b5884f39e279fc1dc87535a7R40 I don't want to duplicate fixing up all the tests for 0.7.0 if I can help it. See https://github.com/kubernetes-sigs/kubebuilder/pull/1790/files#r518356945 for @Adirio and @camilamacedo86's feedback |
@christopherhein agreed, but for tests to pass kubernetes-sigs/kubebuilder-declarative-pattern#127 needs to be merged first. |
a22ca3d
to
7eab12b
Compare
Closing, see #1787 (comment) |
Reopening to add tests so reverted PR's can be re-submitted. |
7eab12b
to
b28c567
Compare
Seems to be some issue with authorization required for leader election:
|
test code such that it is easier to add other plugin tests going forward. test/e2e/utils: add util to remove tool binaries from path test/e2e/v3: refactor generation code so all plugins can be tested test/e2e/v2: rename test files *: clean up scripts
b28c567
to
c4f88e2
Compare
Once #1809 (linked above) gets merged, this may need a rebase. |
/test pull-kubebuilder-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds e2e tests for go/v3-alpha and refactors test code such that it is easier to add other plugin tests going forward.
Pulls refactoring/cleanup from #1644