🐛 (go/v3-alpha) add leases.coordination.k8s.io to leader-election-role #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Role under the same rule as configmaps. These permissions are required by default by controller-runtime's leader election, which uses configmapsleases as the default election type. go/v3-alpha: add leases.coordination.k8s.io to leader election RBAC
estroz
force-pushed
the
chore/leader-election-leases
branch
from
f38bf3a
to
f6d54b9
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Echoing a comment from Slack so it doesn't get lost, we should probably do a follow up to this where we split this object to its own rule chunk in the role so it's not granting the non-existent perms core/leases and leases.coordination.k8s.io/configmap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
leases.coordination.k8s.ioto the leader-election-role Role under the same rule asconfigmaps. These permissions are required by default by controller-runtime's leader election, which uses "configmapsleases" as the default election type.