Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Revert "⚠️ upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only)" #1807

Merged
merged 1 commit into from
Nov 10, 2020
Merged

🌱 Revert "⚠️ upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only)" #1807

merged 1 commit into from
Nov 10, 2020

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Nov 10, 2020 •
edited

Reverts #1787, which breaks go/v3-alpha:

This PR broke go/v3-alpha silently because testdata generation can only use one tool version per script invocation, i.e. all testdata is generated with controller-gen v0.3.0 right now. This blocks #1756, so we'll have to go ahead and merge its parent PR #1644 to fix go/v3-alpha.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@estroz estroz mentioned this pull request Nov 10, 2020
Merged
@estroz
Copy link
Contributor Author

estroz commented Nov 10, 2020

/retest

@estroz
Copy link
Contributor Author

estroz commented Nov 10, 2020

/assign @camilamacedo86

@estroz estroz changed the title Revert ":warning: upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only)" :seeding: Revert "⚠️ upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only)" Nov 10, 2020
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@estroz estroz changed the title :seeding: Revert "⚠️ upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only)" 🌱 Revert "⚠️ upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only)" Nov 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7db6812 into kubernetes-sigs:master Nov 10, 2020
@estroz estroz deleted the revert-1787-upgrade-controller-gen branch November 10, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@estroz @k8s-ci-robot @camilamacedo86