tests: run with a known version of kubectl #289
Conversation
k8s-ci-robot
added
cncf-cla: yes
justinsb
force-pushed
the
fix_kubectl_version
branch
2 times, most recently
from
68617ec
to
1e6513c
Compare
|
Getting this to pass reliably probably depends on #287 |
justinsb
force-pushed
the
fix_kubectl_version
branch
2 times, most recently
from
ff60ef0
to
f9dc0fe
Compare
Update hack/ci/test.sh to download kubectl and add it to the path. Add dev/update-golden to generate golden output with the kubectl version. We run with kubectl 1.26 so that we get the fast-discovery, as this is expected to roll out more generally over the next few months.
justinsb
force-pushed
the
fix_kubectl_version
branch
from
f9dc0fe
to
59f1e09
Compare
| @@ -144,6 +144,18 @@ metadata: | |||
| } | |||
|
|
|||
| func TestKubectlApplier(t *testing.T) { | |||
| kubectlPath, err := exec.LookPath("kubectl") | |||
There was a problem hiding this comment.
would this prefer ./bin over standard paths ?
There was a problem hiding this comment.
Only if ./bin is set in the PATH, which we do here :-)
The goal here is primarily to give a nice error if kubectl isn't on the path, but also to print the path to kubectl and the version we found, so that if something weird happens that looks like a kubectl version issue we can figure out what the problem is from the logs!
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update hack/ci/test.sh to download kubectl and add it to the path.
Add dev/update-golden to generate golden output with the kubectl version.
We run with kubectl 1.26 so that we get the fast-discovery, as this is
expected to roll out more generally over the next few months.