Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README about required go version #290

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Update README about required go version #290

merged 1 commit into from
Jan 13, 2023

Conversation

CatherineF-dev
Copy link
Contributor

What this PR does / why we need it:

2023/01/04 15:52:14 failed to initialize project: unable to run pre-scaffold tasks of "base.go.kubebuilder.io/v3": go version 'go1.17' is incompatible because 'requires 1.13 <= version < 1.17'. You can skip this check using the --skip-go-version-check flag

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

@CatherineF-dev
Update README about required go version
f1fa94b 
```
2023/01/04 15:52:14 failed to initialize project: unable to run pre-scaffold tasks of "base.go.kubebuilder.io/v3": go version 'go1.17' is incompatible because 'requires 1.13 <= version < 1.17'. You can skip this check using the --skip-go-version-check flag
```
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 4, 2023
@justinsb
Copy link
Contributor

Thank you - ideally we would be compatible with later versions of go, but maybe #291 will fix that. I agree with documenting it in the meantime.

Test failure looks unrelated (and I think we have an open PR for it as well, I think it's #289):
/retest

@camilamacedo86 camilamacedo86 mentioned this pull request Jan 11, 2023
Merged
@justinsb
Copy link
Contributor

/retest

@justinsb
Copy link
Contributor

Thank you @CatherineF-dev

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit c3e56ed into kubernetes-sigs:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 Awaiting requested review from atoato88

@johnsonj johnsonj Awaiting requested review from johnsonj

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CatherineF-dev @justinsb @k8s-ci-robot