Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ bump k8s from 1.25 to 1.26 #291

Merged
merged 1 commit into from
Jan 13, 2023
Merged

✨ bump k8s from 1.25 to 1.26 #291

merged 1 commit into from
Jan 13, 2023

Conversation

camilamacedo86
Copy link
Member

What this PR does / why we need it:

We need to bump the k8s version in this project to be able to support the new version in kubebuilder

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2023
@justinsb
Copy link
Contributor

Thanks for this @camilamacedo86 .... I'm thinking if we can get #292 in then we can probably be more version-independent on our code.

If we do have to add the new methods, that isn't really a blocker though either, we have a release-0.13 branch which corresponds to controller-runtime 0.13, so we can just treat our main branch as 0.14.

(We should probably also consider numbering that is more client-friendly, i.e. more aligned to k8s versioning!)

@camilamacedo86
Copy link
Member Author

@johnsonj @justinsb @atoato88, we need to move forward with this one.
It is blocking kubebuilder.

See that the job pull-declarative-test is broken , check the open PRs in the repo. Example: #290

Could we force this one?

@shane

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jan 13, 2023

Hi @justinsb,

Thank you a lot. It is rebased with the master now.
Currently we use the commits and not the branches there, but we

we can probably be more version-independent on our code.

In Kubebuilder we have now implemented: https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/extensible-cli-and-scaffolding-plugins-phase-2.md

That means we could move the declarative plugin to this repo which has its code. Therefore, we would release from here the plugin and not no longer be in Kubebuilder. However, Kubebuilder users would still be able to use it with the projects.

That would decouple and might help us keep a better quality of the plugin since it might get outdated many times because we are not synced with the latest changes. We can speak and look at the future.

I will raise an issue in this repo with the proposal then, we can discuss it. I think it also can make easier the tests done in this repository. Let's see.

If we do have to add the new methods, that isn't really a blocker though either; we have a release-0.13 branch which corresponds to controller-runtime 0.13, so we can just treat our main branch as 0.14.

We use commits there and not branches. So, when this PR get merged we are good to fly.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 13, 2023
@justinsb
Copy link
Contributor

Thanks @camilamacedo86 - that's a great roadmap!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit ce5e62e into kubernetes-sigs:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants