Merge pull request #1460 from camilamacedo86/minimal-go

update the go check for the minimal required version
kubernetes-sigs · Apr 2, 2020 · f722914 · f722914
2 parents 29d1dc1 + 91eb0e1
commit f722914
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/cmd/internal/go_version.go b/cmd/internal/go_version.go
@@ -68,8 +68,8 @@ func checkGoVersion(verStr string) error {
 		return fmt.Errorf("error parsing minor version '%s': %s", m[2], err)
 	}
 
-	if major < 1 || minor < 11 {
-		return fmt.Errorf("requires version >= 1.11")
+	if major < 1 || minor < 13 {
+		return fmt.Errorf("requires version >= 1.13")
 	}
 
 	return nil

diff --git a/cmd/internal/go_version_test.go b/cmd/internal/go_version_test.go
@@ -29,10 +29,10 @@ func TestCheckGoVersion(t *testing.T) {
 		{"go1.8", true},
 		{"go1.9", true},
 		{"go1.10", true},
-		{"go1.11", false},
-		{"go1.11rc", false},
-		{"go1.11.1", false},
-		{"go1.12rc2", false},
+		{"go1.11", true},
+		{"go1.11rc", true},
+		{"go1.11.1", true},
+		{"go1.12rc2", true},
 		{"go1.13", false},
 	}