Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the go check for the minimal required version #1460

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

camilamacedo86
Copy link
Member

Description
Upgrade the go check to ensure that the version used is according to the minimal requirements

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@Adirio
Copy link
Contributor

Adirio commented Apr 2, 2020

IIRC I already tried this and there were more changes needed. Some involved modifying some of the CI tools (not sure if it was Travis, Prow, KinD or the api server images). Also, you would need to require 13+ in

if major < 1 || minor < 11 {
return fmt.Errorf("requires version >= 1.11")
}

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2020
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Apr 2, 2020

@Adirio,

IIRC I already tried this and there were more changes needed. Some involved modifying some of the CI tools (not sure if it was Travis, Prow, KinD or the api server images). Also, you would need to require 13+ in

Did you find any place that is using a go version < 1.13 ?

See that Travis is using 1.13 and it is the info the Kubebuilder docs as well. Also, since all CI tests passed with the check I would assume that has not a place using a lower version too.

However, please let me know if you see any reason we do not move forward here.

Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remembered one of the tests failing but it doesn't seem to happen so:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit f722914 into kubernetes-sigs:master Apr 2, 2020
@Adirio
Copy link
Contributor

Adirio commented Apr 2, 2020

I didn't realize that a lgtm was going to merge it.

@DirectXMan12 @mengqiy @droot if you consider this shouldn't be merged we can clease the mess, sorry.

@camilamacedo86 camilamacedo86 deleted the minimal-go branch April 3, 2020 09:23
@mengqiy
Copy link
Member

mengqiy commented Apr 13, 2020

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants