-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold a dockerignore file #1246
Comments
/help Sounds like a good plan |
@DirectXMan12: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding Which should be the approach related to backwards compatibility? Previously scaffolded projects will not have this file. Are we ok with that? Would this have to wait for |
it's generally safe to introduce new files in an existing version if they're scaffolded on initial scaffold, I think. We just can't later assume that file will always be there. Not sure if that's sane from maintainability, but I think its safe compat-wise. Could we do This kinda thing makes me really appreciate Bazel's ability to actually track dependencies... |
/assign @camilamacedo86 |
I've noticed that Docker build context can be significantly larger then necessary; this isn't a huge problem but it can be noticeable at times. Scaffolding a
.dockerignore
file was previously suggested, but in the context of eliminatingCOPY
statements (which negatively impacts the build cache); this is more about just reducing the build context size.I am currently using a
.dockerignore
similar to this in my projects to ensure only the Go code is included in the build context (although just ignoring/bin
and/.git
can make a big difference):/kind feature
The text was updated successfully, but these errors were encountered: