Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dockerignore file to the scaffold (V3 only) #1506

Merged
merged 1 commit into from
Jun 30, 2020
Merged

feat: add dockerignore file to the scaffold (V3 only) #1506

merged 1 commit into from
Jun 30, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 8, 2020 •
edited
Loading

Closes: #1246

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2020
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-14-1

@camilamacedo86
Copy link
Member Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 30, 2020
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented May 30, 2020 •
edited
Loading

/hold

Are you ok @DirectXMan12 one for V2 as well?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2020
@camilamacedo86
Copy link
Member Author

/assign @DirectXMan12

@DirectXMan12
Copy link
Contributor

should this be part of #1498 ?

@DirectXMan12
Copy link
Contributor

otherwise seems fine

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jun 1, 2020 •
edited
Loading

Hi @DirectXMan12,

This was my doubt. really thank you for your input.

/hold until we are able to have +1 plugin merged and we address it as a new bump plugin version.

@camilamacedo86 camilamacedo86 changed the title feat: add dockerignore file to the scaffold WIP (Address to plugins X.+1 version) feat: add dockerignore file to the scaffold (V3 only) Jun 1, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 1, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2020
@camilamacedo86 camilamacedo86 changed the title WIP (Address to plugins X.+1 version) feat: add dockerignore file to the scaffold (V3 only) feat: add dockerignore file to the scaffold (V3 only) Jun 19, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2020
@camilamacedo86
Copy link
Member Author

/hold cancel
Applied for v3-alpha now.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-17-0

@pwittrock
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-15-3

@k8s-ci-robot k8s-ci-robot merged commit 3834394 into kubernetes-sigs:master Jun 30, 2020
@camilamacedo86 camilamacedo86 deleted the add-dockerignore branch June 30, 2020 01:02
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirio Adirio Awaiting requested review from Adirio

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@DirectXMan12 DirectXMan12

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaffold a dockerignore file
4 participants
@camilamacedo86 @k8s-ci-robot @DirectXMan12 @pwittrock