-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Kustomize Dependency for make install
#1371
Comments
Kubebuilder book mentions kustomize in prerequisites section in quick-start-guide. Though better error message pointing to kustomize install page would be great help here. |
/assign |
It is not about the makefile of the kubebuilder project. The makefile in the kubebuilder project are targets which are helpful for who will contribute with the project. In this scenario, the user says So, what @droot is suggesting here as the solution is: Improve the error face in this scenario in order to allow users to know that the prerequisite kustomize is not installed. Also, I would recommend we solve it by checking the pre-requirement is install as we do for the Go version see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/cmd/internal/go_version.go |
I agree with @camilamacedo86 that checking the dependency could be done. I don't think there is any other easy way to improve the error message, as it is a OS error not one we are printing, so we need to check for it before running any kustomize command. |
Feel free to do. the. other checks if you see that would be nice. To close this one IHMO doing it for kustomize only would be enough. |
I also wanted to move this check out of |
This commit checks that the prequisites listed in the Kubebuilder book are in `$PATH` before proceeding with any target. We probably want the user to get better feedback up front instead of `make` failing half-way through (possibly) Fixes kubernetes-sigs#1371
This commit checks that the prerequisites listed in the Kubebuilder book are in `$PATH` before proceeding with any target. We probably want the user to get better feedback up front instead of `make` failing half-way through (possibly) Fixes kubernetes-sigs#1371
Eek. I didn't realize this was assigned to someone else (its 2AM here and I'm unable to sleep) Didn't mean to step on someone else that was interested in doing this. I ran into this issue tonight as I just rely on |
@dmizelle no worries, I have not got around to it yet, so go ahead. |
Once #1430 is merged, kustomize will be installed automatically when not present in PATH. |
So we could either install or just check for the dependency. Both aproaches are being used currently: go version is checked while controller-gen is installed if not present. I'm not sure which of them feels better. @mengqiy @droot @DirectXMan12 what approach do you prefer?
|
I've commented this on #1430, but ideally the dependencies like controller-gen and kustomize should only be installed locally (eg. local to the project). This could be in As they are internal dependencies in my opinion, they should not change the external environment (and ideally not be influenced by it either, all though that would break backwards compatibility). Anyways, this is perfectionistic, so I would simply go with #1430 as well! |
I do agree that having a |
IHMO, the kustomize is a requirement dependence such as the controller-gen and the solution in #1430 make it easier for the users and bring better experience, also address the issue raised here and still allowing users customize it according to their needs since the implementation is in the makefile. Then, I cannot see any reason why not move forward with #1430. @mengqiy @DirectXMan12 wdyt ? |
@droot @mengqiy @DirectXMan12 would you mind answering the poll raised in this #1371 (comment)? |
/close It was solved with #1430 |
@camilamacedo86: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fresh linux system, trying to go through the getting started
Either docs that mention this, a check in
make install
, a better error message with a path forward, or includingkustomize
in thebuild/bin/
directory of a release/kind bug
The text was updated successfully, but these errors were encountered: