Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Dependencies checks #1428

Closed
wants to merge 2 commits into from
Closed

[WIP] Dependencies checks #1428

wants to merge 2 commits into from

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Mar 12, 2020

Description

Cleans dependency version checks and adds one for kustomize.

Motivation

Fixes #1371

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Adirio
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Adirio Adirio force-pushed the dependency-checks branch 3 times, most recently from b02285b to dd166f4 Compare March 12, 2020 10:35
@Adirio
Clean go version check and add kustomize version check
0fc8966 
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@Adirio Adirio force-pushed the dependency-checks branch 4 times, most recently from b2b6440 to 9c035d2 Compare March 12, 2020 12:51
@k8s-ci-robot
Copy link
Contributor

@Adirio: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-test 7e59df2 link /test pull-kubebuilder-test
pull-kubebuilder-e2e-k8s-1-17-0 7e59df2 link /test pull-kubebuilder-e2e-k8s-1-17-0
pull-kubebuilder-e2e-k8s-1-16-2 7e59df2 link /test pull-kubebuilder-e2e-k8s-1-16-2
pull-kubebuilder-e2e-k8s-1-15-3 7e59df2 link /test pull-kubebuilder-e2e-k8s-1-15-3
pull-kubebuilder-e2e-k8s-1-14-1 7e59df2 link /test pull-kubebuilder-e2e-k8s-1-14-1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Adirio
Copy link
Contributor Author

Adirio commented Mar 12, 2020

Errors in Travis and pull-kubebuilder-test are expected as those tests are being run in images that do not have the kustomize dependency. Still have to debug the rest.

pull-kubebuilder-test image configuration: link

@Adirio Adirio mentioned this pull request Mar 12, 2020
Closed
@Adirio
Copy link
Contributor Author

Adirio commented Mar 14, 2020

/hold until #1371 discussion is settled

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2020
estroz
estroz reviewed Mar 22, 2020
View reviewed changes
cmd/internal/dependencies/semantic_version.go
"strconv"
)

const semanticVersionPattern = `v?(?P<major>\d+)(?:\.(?P<minor>\d+)(?:\.(?P<patch>\d+))?)?(?P<extra>[\w\.-]+)?`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of re-implementing semver parsing, can a library like blang/semver be used? Plugin version enforcement is already using this library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it support 1.14rc? I think that may not technichally be a semantic version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, some pre-processing would need doing for atypical semver strings. Most of the semver processing logic implemented in this PR exists in the linked library. Check it out, see if it can be dropped in easily.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2020
@k8s-ci-robot
Copy link
Contributor

@Adirio: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member

Hi @Adirio,

Thee issue was solved with the makefile solution in #1430 so I understand that has no reason for we keep this PR. In this way, I am casing this one. However, please feel free to re-open if you see anything that should be addressed with. Really tks for your collab. 🥇

/close

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Closed this PR.

In response to this:

Hi @Adirio,

Thee issue was solved with the makefile solution in #1430 so I understand that has no reason for we keep this PR. In this way, I am casing this one. However, please feel free to re-open if you see anything that should be addressed with. Really tks for your collab. 🥇

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Adirio Adirio deleted the dependency-checks branch February 9, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Kustomize Dependency for make install
4 participants
@Adirio @k8s-ci-robot @camilamacedo86 @estroz