-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build-related flags for executables built from source #1401
Comments
The four variables in the second group could be set as part of the |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@Adirio: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lifecycle frozen |
@estroz suggested some commands to fetch this data and I would like to expand on them:
P.S.: I removed the |
Description
Currently, when
kubebuilder
is built from source,kubebuilder version
yields:These variables are set as part of the automated build process, but they are never stored in the release branch. they can be found in
kubebuilder/cmd/version/version.go
Lines 27 to 35 in 9552d12
Feature request
Set these flags as part of the development process instead so that, if kubebuilder is built from a release branch, even if it is from source, this fields will be set to provide useful information.
There are three types of variables:
kubeBuilderVersion
: should be set in the branch.goos
: can't be stored in the release branch as there is no one branch per target.goarch
: same.gitCommit
: the git commit sha1 can't be obtained before commiting the release, so it needs to be set afterwards.buildDate
: obvious reasons.kubernetesVendorVersion
: has no meaning when building from source./kind feature
/kind documentation
The text was updated successfully, but these errors were encountered: