🌱 Set build variables during make build
#1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/cc @estroz |
estroz
suggested changes
Nov 11, 2020
Adirio
force-pushed
the
build-variables
branch
from
d847ced
to
086960b
Compare
|
@estroz all suggestions applied |
Adirio
force-pushed
the
build-variables
branch
from
086960b
to
65c1de7
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Adirio
force-pushed
the
build-variables
branch
from
65c1de7
to
667ec04
Compare
k8s-ci-robot
removed
the
lgtm
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
Adirio
force-pushed
the
build-variables
branch
from
667ec04
to
dd18973
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several variables are set when releasing a kubebuilder version in order to output the correct information when calling
kubebuilder version. But when building from the source withmake build, this variables were not being set, and thus thekubebuilder versionoutput was providing no information:This PR updates those variables to reflect the current working environment.
Fixes #1401
P.S.: it also cleans a bit the
Makefile