-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Set build variables during make build
#1814
Conversation
/cc @estroz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions
d847ced
to
086960b
Compare
@estroz all suggestions applied |
086960b
to
65c1de7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
65c1de7
to
667ec04
Compare
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
667ec04
to
dd18973
Compare
/lgtm |
Description
Several variables are set when releasing a kubebuilder version in order to output the correct information when calling
kubebuilder version
. But when building from the source withmake build
, this variables were not being set, and thus thekubebuilder version
output was providing no information:This PR updates those variables to reflect the current working environment.
Fixes #1401
P.S.: it also cleans a bit the
Makefile