⚠️ (go/v3-alpha) Makefile: install kustomize and controller-gen locally #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
estroz
force-pushed
the
chore/improve-tool-downloads
branch
2 times, most recently
from
5b324df
to
ecdff22
Compare
'<project root>/bin', and always use these instead of global binaries
estroz
force-pushed
the
chore/improve-tool-downloads
branch
from
ecdff22
to
11d4c8f
Compare
generate_testdata.sh,test.sh: use 'command -v', which won't print if a binary isn't found, over 'which' to avoid unnecessary error text
estroz
force-pushed
the
chore/improve-tool-downloads
branch
from
11d4c8f
to
f4d30ae
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the Makefile so that it installs kustomize and controller-gen to
<project root>/binif they do not exist. Targets will always use these binaries instead of installing global binaries, which pollutes userspace. Users can still use their preferred binary by runningThis PR also cleans up the top-level Makefile and scripts.