-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add envtest example for CronJob controller #1518
Comments
/remove-kind feature |
/cc @mengqiy |
I’ve been working on docs for a generalized approach to envtest in the context of writing tests for the CronJob example :) Planning on opening a PR for it tomorrow morning, and I’ll reference it here. (It will be my first kubebuilder project PR so I will especially appreciate feedback/guidance on it). |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Entrypoint docs for envtest, in the context of the cronjob tutorial, were put into the production kubebuilder book with PR #1579. I think we can consider this issue closed :) |
/close |
@gabbifish: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As I was reading the docs for envtest I see the following:
I assume
more documentation
probably meant the following sub-section that was added later on which covers the setup and configuration of envtest but references no example test for users to look at.https://book.kubebuilder.io/reference/testing/envtest.html
While the Azure Databricks Operator example seems sufficient I was wondering if it would be beneficial to have a envtest example for the CronJob controller itself so that we have a canonical example to reference within the repo.
Low priority but I wanted to see if there's interest in this before trying to write any tests for the CronJob controller.
/kind documentation
The text was updated successfully, but these errors were encountered: