Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envtest example for CronJob controller #1518

Closed
hasbro17 opened this issue May 15, 2020 · 7 comments
Closed

Add envtest example for CronJob controller #1518

hasbro17 opened this issue May 15, 2020 · 7 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@hasbro17
Copy link

As I was reading the docs for envtest I see the following:

Until more documentation has been written, your best bet to get started is to look at some existing examples, such as:

  • Azure Databricks Operator: see their fully fleshed-out suite_test.go as well as any *_test.go file in that directory like this one.

I assume more documentation probably meant the following sub-section that was added later on which covers the setup and configuration of envtest but references no example test for users to look at.
https://book.kubebuilder.io/reference/testing/envtest.html

While the Azure Databricks Operator example seems sufficient I was wondering if it would be beneficial to have a envtest example for the CronJob controller itself so that we have a canonical example to reference within the repo.

Low priority but I wanted to see if there's interest in this before trying to write any tests for the CronJob controller.

/kind documentation

@hasbro17 hasbro17 added the kind/feature Categorizes issue or PR as related to a new feature. label May 15, 2020
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 15, 2020
@hasbro17
Copy link
Author

/remove-kind feature

@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label May 15, 2020
@hasbro17
Copy link
Author

/cc @mengqiy

@gabbifish
Copy link
Contributor

I’ve been working on docs for a generalized approach to envtest in the context of writing tests for the CronJob example :) Planning on opening a PR for it tomorrow morning, and I’ll reference it here. (It will be my first kubebuilder project PR so I will especially appreciate feedback/guidance on it).

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2020
@gabbifish
Copy link
Contributor

Entrypoint docs for envtest, in the context of the cronjob tutorial, were put into the production kubebuilder book with PR #1579. I think we can consider this issue closed :)

@gabbifish
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@gabbifish: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants