-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick envtest example #1579
Cherry-pick envtest example #1579
Conversation
Hi @gabbifish. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@camilamacedo86 would love your review on this! :) |
/retest |
@gabbifish: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc5eb53
to
b3d11d9
Compare
hi @gabbifish, It is not passing in the tests. See that it is failing the test to check if the testdata was generated. The testdata is updated with the command However, I do not think that is required to do the cherry-pick the docs will be updated in the next release. But if you wish to check it in the book now then, to make the cherry-pick is required to do the fixes to allow it pass. E.g https://github.com/kubernetes-sigs/kubebuilder/pull/1554/files |
@camilamacedo86 Hey there! Yeah, I'm trying to figure out the tricky |
b3d11d9
to
34defe5
Compare
@camilamacedo86 The tests are passing--I think this should be ready for review/merge! :) |
Hi @gabbifish, See that your change broke the docs. We need to fix it in the master as soon as possible. Could you please check that? See that in the master we have: https://book.kubebuilder.io/reference/writing-tests.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bug was introduced in the master regards these changes made in the docs. It needs to be fixed to be cherry-picked here as well.
/hold
/hold |
Hi @gabbifish, Could you check my above comment? Wdyt about addressing the fix for the docs in master first? Are you able to help with? Do you think that we need to track an issue to fix the docs? |
Hi @camilamacedo86! I went back to try and find the docs rendering errors I might have introduced, but it looks like https://deploy-preview-1579--kubebuilder.netlify.app/cronjob-tutorial/writing-tests.html looks correct now--did the fix from master get cherry-picked into this branch already? Please let me know if there are still issues! |
Hi @gabbifish, I think that I found the root cause. See:
In the PR shows that a new sub-menu was created when I understand that we should use the pre-existence one : See: It should be in the references (writing controller test): When it is in the tutorial (writing tests): I think the fix that needs to be done in the master and then cherrry-picked to here 👍 |
Cherry-picked the fix from master to this branch! Let me know how things look--I checked that the links to https://deploy-preview-1579--kubebuilder.netlify.app/reference/envtest.html worked from both the sidebar (4.8, Configuring EnvTest) and the link at the top of https://deploy-preview-1579--kubebuilder.netlify.app/cronjob-tutorial/writing-tests.html :D |
/retest |
Oop, looks like i need to rebase on this branch again to fix travis CI (I see some dependency issues) |
…sting-docs Add envtest testing docs to extend cronjob example
Fix old link to envtest docs that should have been removed
143746c
to
2ff620f
Compare
cc @camilamacedo86 this should pass Travis CI now, but I ran into some weird dependency problems along the way. Even though this PR does nothing to change the dependencies in the root |
HI @gabbifish, Note that the common process is just performed merges here when we do the release and all from the master will be added. However, we also can cherry-pick something from the master but in some scenarios, it might need some adjustments as you did. It is ok for now. However, I am quite sure that we would be able to improve the process and perform changes. I think ideally we need to raise our suggestions and make a proposal. Maybe this kind of discussion can be started in an issue. WDYT? |
/ok-to-test |
/hold cancel |
It is just a cherry-picks for docs. So, it shows fine and required to go alive since many users have been asking for further info over how to test their controllers. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, gabbifish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR cherry-picks the new envtest documentation for the cronjob example.