Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to use the latest version of kustomize #1657

Closed
camilamacedo86 opened this issue Sep 1, 2020 · 4 comments · Fixed by #1838
Closed

upgrade to use the latest version of kustomize #1657

camilamacedo86 opened this issue Sep 1, 2020 · 4 comments · Fixed by #1838
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v3.0.0

Comments

@camilamacedo86
Copy link
Member

camilamacedo86 commented Sep 1, 2020 •
edited

WHAT

  • Upgrade to use the latest version of kustomize
  • The latest version is 3.8.2 currently.
  • Sheck if the kb workflow will be impacted by Avoiding Prefix Transformer for Namespace resource kustomize#2742. (See if the namespace will still be created or not). If not, it is required to investigate if it means a breaking change required in the kb scaffold project or if it should be addressed in the kustomize.

NOTE: The change should be made only for v3+

Motivation

  • Solve technical debts
  • Ensure that an issue/or new bahaviour was not introduced to kustomize which affects kb projects.
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 1, 2020
@camilamacedo86 camilamacedo86 mentioned this issue Sep 1, 2020
Closed
@rmb938
Copy link
Contributor

rmb938 commented Sep 14, 2020

That kustomize change makes it so namespaces no longer use the name prefix...

So when I go and kustomize build the files kubebuilder generates the namespace no longer has the prefix.

@camilamacedo86
Copy link
Member Author

Confirmed that:

With kustomize 3.7.0 the patched namespace has name:example-system while in 3.8.2 this is kept as name:system

see: kubernetes-sigs/kustomize#3005

@camilamacedo86 camilamacedo86 mentioned this issue Sep 18, 2020
Closed
@camilamacedo86 camilamacedo86 mentioned this issue Oct 21, 2020
Closed
@camilamacedo86
Copy link
Member Author

Another scenario that required be checked/fixed with the upgrade is: #1633

@camilamacedo86 camilamacedo86 added this to the v3+ plugin milestone Nov 3, 2020
@camilamacedo86 camilamacedo86 added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 3, 2020
@estroz
Copy link
Contributor

estroz commented Nov 17, 2020

when I go and kustomize build the files kubebuilder generates the namespace no longer has the prefix.

I'm not seeing this behavior with kustomize v3.8.7. kubebuilder init scaffolds a config/default/kustomization.yaml with namespace: {{ .ProjectName }}-system, which gets applied to every namespaced object.

@estroz estroz mentioned this issue Nov 17, 2020
Merged
@camilamacedo86 camilamacedo86 modified the milestones: v3+ plugin, v3.0.0 Nov 18, 2020
mnencia added a commit to cloudnative-pg/cloudnative-pg that referenced this issue Apr 1, 2022
@mnencia
Pin kustomize version to v3.5.4
7346d8a 
Kustomize 3.8.2 is not compatible with kubebuilder,
see kubernetes-sigs/kubebuilder#1657

To make sure the build uses a version that is compatible we
download it from the makefile.

Co-authored-by: Marco Nenciarini <marco.nenciarini@2ndquadrant.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

✨ go/v3-alpha: bump KustomizeVersion to v3.8.7 estroz/kubebuilder
3 participants
@rmb938 @camilamacedo86 @estroz