-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ go/v3-alpha: bump KustomizeVersion to v3.8.7 #1838
✨ go/v3-alpha: bump KustomizeVersion to v3.8.7 #1838
Conversation
a29c62d
to
b8347b0
Compare
/retest |
3 similar comments
/retest |
/retest |
/retest |
/test pull-kubebuilder-e2e-k8s-1-16-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the version 3.8.7 and I could not face the scenario reported with 3.8.2 see:
$ bin/kustomize build config/default | kubectl apply -f -
namespace/project-v3-system unchanged
customresourcedefinition.apiextensions.k8s.io/admirals.crew.testproject.org configured
customresourcedefinition.apiextensions.k8s.io/captains.crew.testproject.org configured
customresourcedefinition.apiextensions.k8s.io/firstmates.crew.testproject.org configured
role.rbac.authorization.k8s.io/project-v3-leader-election-role unchanged
clusterrole.rbac.authorization.k8s.io/project-v3-manager-role configured
clusterrole.rbac.authorization.k8s.io/project-v3-metrics-reader unchanged
clusterrole.rbac.authorization.k8s.io/project-v3-proxy-role unchanged
rolebinding.rbac.authorization.k8s.io/project-v3-leader-election-rolebinding unchanged
clusterrolebinding.rbac.authorization.k8s.io/project-v3-manager-rolebinding unchanged
clusterrolebinding.rbac.authorization.k8s.io/project-v3-proxy-rolebinding unchanged
service/project-v3-controller-manager-metrics-service unchanged
deployment.apps/project-v3-controller-manager unchanged
Also, I was unable to reproduce the scenario: #1633
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR bumps
kustomize
version installed by the go/v3-alpha plugin to v3.8.7.Closes #1657
/cc @camilamacedo86