Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liveness/readiness probe scaffolded by default #1761

Closed
camilamacedo86 opened this issue Oct 30, 2020 · 3 comments · Fixed by #1795 or #1856
Closed

liveness/readiness probe scaffolded by default #1761

camilamacedo86 opened this issue Oct 30, 2020 · 3 comments · Fixed by #1795 or #1856
Assignees
@camilamacedo86 @prafull01
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
3.1.0

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?
I would like to see liveness/readiness probe for operators scaffolded by default

Is there currently another issue associated with this?

operator-framework/operator-sdk#4102

PS.: also, it cames as requested in a survey

/kind feature
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 30, 2020
@camilamacedo86 camilamacedo86 changed the title liveness/readiness probe for operators scaffolded by default liveness/readiness probe scaffolded by default Oct 30, 2020
@camilamacedo86
Copy link
Member Author

See that the manager has the options :

	// HealthProbeBindAddress is the TCP address that the controller should bind to
	// for serving health probes
	HealthProbeBindAddress string

	// Readiness probe endpoint name, defaults to "readyz"
	ReadinessEndpointName string

	// Liveness probe endpoint name, defaults to "healthz"
	LivenessEndpointName string

More info: https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.6.3/pkg/manager#Manager

@prafull01
Copy link
Contributor

/assign

@prafull01 prafull01 mentioned this issue Nov 5, 2020
Merged
@camilamacedo86 camilamacedo86 self-assigned this Nov 10, 2020
@camilamacedo86 camilamacedo86 added this to the v3+ plugin milestone Nov 10, 2020
@camilamacedo86 camilamacedo86 mentioned this issue Nov 10, 2020
Closed
@camilamacedo86 camilamacedo86 modified the milestones: v3+ plugin, 3.1.0 Nov 17, 2020
@prafull01 prafull01 mentioned this issue Nov 21, 2020
Merged
@camilamacedo86
Copy link
Member Author

Closing in favor of 1856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilamacedo86 camilamacedo86

@prafull01 prafull01

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
3.1.0
2 participants
@camilamacedo86 @prafull01