-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ✨ Add the liveness and readiness probe in the manager deployment #1811
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
livenessProbe: | ||
httpGet: | ||
path: /readyz | ||
port: 9443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to set HealthProbeBindAddress
in main.go
for this to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #1856
8ddbdee
to
133e059
Compare
133e059
to
b88d9fd
Compare
@@ -260,6 +264,9 @@ func main() { | |||
|
|||
%s | |||
|
|||
_ = mgr.AddHealthzCheck("check", func(_ *http.Request) error { return nil }) | |||
_ = mgr.AddReadyzCheck("check", func(_ *http.Request) error { return nil }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required to check we really need to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified that we need this change to actually serve the readyz and healthz endpoints
b88d9fd
to
c93d4a3
Compare
@@ -21,5 +21,6 @@ spec: | |||
name: https | |||
- name: manager | |||
args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might need to setup the auth proxy to allow that ( - -skip-auth-regex=^/readyz )
@camilamacedo86: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@camilamacedo86: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@camilamacedo86 asked me to see this through while she is on PTO. I have raised another PR #1856 for this. Hence this PR can be closed. |
description
Cherry-pick of #1795
motivation
Re-introduce the change to close the #1761
Note that it was reverted because the CI was not doing tthe e2e tests with the v3-alpha plugin which is done now.