Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add the liveness and readiness probe in the manager deployment #1795

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

prafull01
Copy link
Contributor

Description
Add the liveness and readiness probe for the manager deployment.

Motivation
Fixes: #1761

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2020
@prafull01
Copy link
Contributor Author

/cc @camilamacedo86

@prafull01
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-17-0

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked this one 🥇 . its motivations came from community requests made in SDK operator-framework/operator-sdk#4102. I pinged it in the slack as well for we get feedback from the community. Let's see.

@christopherhein
Copy link
Member

christopherhein commented Nov 6, 2020

Seems pretty low risk and a good addition to level up the base scaffolding. Before #1790 is done I'll need to make sure we don't change the 9443 port and the default health/ready endpoint paths.

lgtm!

@camilamacedo86
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, prafull01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@camilamacedo86
Copy link
Member

I think it is fine to get merged so;
/lgtm

@estroz
Copy link
Contributor

estroz commented Nov 10, 2020

@prafull01 did you manually test this change? I don't think these endpoints are available by default.

@prafull01
Copy link
Contributor Author

@estroz Hi Eric, I thought the following e2e scenario would cover the checking of controller-manager coming up:

By("validate the controller-manager pod running as expected")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

liveness/readiness probe scaffolded by default
5 participants