-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
❓ / 🌱 Flag names and messages on built-in flag messages #1839
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
Comments
/assign |
@camilamacedo86 @DirectXMan12 @estroz @gabbifish since we're doing the component config work, do you think it would be advantageous to also change the v3-alpha flag names and values when component config is off to match other standard kubernetes resources like Kube-proxy for |
sgtm |
ansd
added a commit
to rabbitmq/cluster-operator
that referenced
this issue
Jul 1, 2021
Use https://github.com/kubernetes-sigs/controller-runtime/tree/master/tools/setup-envtest since we want self-contained test dependencies for our integration tests. Migrate PROJECT file to kubebuilder v3 see https://kubebuilder.io/migration/manually_migration_guide_v2_v3.html Delete webhook files We don't use a webhook in the cluster-operator at the moment. Therefore delete the files. If we need a webhook in the future, we can easily re-create the files using 'kubebuilder create webhook' command. Rename flag metrics-addr to metrics-bind-address as described in https://kubebuilder.io/migration/manually_migration_guide_v2_v3.html#rename-the-manager-flags and kubernetes-sigs/kubebuilder#1839 Co-authored-by: Chunyi Lyu <clyu@pivotal.io>
Fedosin
added a commit
to Fedosin/cluster-api-operator
that referenced
this issue
Apr 24, 2023
In kubebuilder the manager flags `--metrics-addr` and `enable-leader-election` were deprecated in favor of --metrics-bind-address and --leader-elect to be more aligned with core Kubernetes Components. For more info: kubernetes-sigs/kubebuilder#1839 All cluster api providers have made related changes. It leads to the fact that when we try to use old flags there, operator returns an error.
Fedosin
added a commit
to Fedosin/cluster-api-operator
that referenced
this issue
Apr 24, 2023
In kubebuilder the manager flags `--metrics-addr` and `enable-leader-election` were deprecated in favor of --metrics-bind-address and --leader-elect to be more aligned with core Kubernetes Components. For more info: kubernetes-sigs/kubebuilder#1839 All cluster api providers have made related changes. It leads to the fact that when we try to use old flags there, operator returns an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Should we follow any of the standard Kubernetes flag names and messages for the built-in flags like
--leader-elect
instead of--enable-leader-election
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-proxy/
/kind feature
The text was updated successfully, but these errors were encountered: