Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❓ / 🌱 Flag names and messages on built-in flag messages #1839

Closed
christopherhein opened this issue Nov 17, 2020 · 3 comments · Fixed by #1852
Closed

❓ / 🌱 Flag names and messages on built-in flag messages #1839

christopherhein opened this issue Nov 17, 2020 · 3 comments · Fixed by #1852
Assignees
@christopherhein
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@christopherhein
Copy link
Member

Should we follow any of the standard Kubernetes flag names and messages for the built-in flags like --leader-elect instead of --enable-leader-election

https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/

--leader-elect     Default: true
Start a leader election client and gain leadership before executing the main loop. Enable this when running replicated components for high availability.

https://kubernetes.io/docs/reference/command-line-tools-reference/kube-proxy/

--metrics-bind-address ipport     Default: 127.0.0.1:10249
The IP address with port for the metrics server to serve on (set to '0.0.0.0:10249' for all IPv4 interfaces and '[::]:10249' for all IPv6 interfaces). Set empty to disable.

/kind feature
@christopherhein christopherhein added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 17, 2020
@christopherhein
Copy link
Member Author

/assign

@christopherhein
Copy link
Member Author

christopherhein commented Nov 17, 2020 •
edited

@camilamacedo86 @DirectXMan12 @estroz @gabbifish since we're doing the component config work, do you think it would be advantageous to also change the v3-alpha flag names and values when component config is off to match other standard kubernetes resources like Kube-proxy for metric-bind-address and leader-elect like kube-scheduler, kube-controller manager etc?

@christopherhein christopherhein mentioned this issue Nov 17, 2020
Open
@estroz
Copy link
Contributor

estroz commented Nov 18, 2020

sgtm

@christopherhein christopherhein mentioned this issue Nov 19, 2020
Merged
ansd added a commit to rabbitmq/cluster-operator that referenced this issue Jul 1, 2021
@ansd @ChunyiLyu
Use setup-envtest
d2aa44d 
Use
https://github.com/kubernetes-sigs/controller-runtime/tree/master/tools/setup-envtest
since we want self-contained test dependencies for our integration tests.

Migrate PROJECT file to kubebuilder v3

see https://kubebuilder.io/migration/manually_migration_guide_v2_v3.html

Delete webhook files

We don't use a webhook in the cluster-operator at the moment.
Therefore delete the files.
If we need a webhook in the future, we can easily re-create the files
using 'kubebuilder create webhook' command.

Rename flag metrics-addr to metrics-bind-address

as described in
https://kubebuilder.io/migration/manually_migration_guide_v2_v3.html#rename-the-manager-flags
and
kubernetes-sigs/kubebuilder#1839

Co-authored-by: Chunyi Lyu <clyu@pivotal.io>
Fedosin added a commit to Fedosin/cluster-api-operator that referenced this issue Apr 24, 2023
@Fedosin
Use correct flags in component customizer
5b8a88a 
In kubebuilder the manager flags `--metrics-addr` and `enable-leader-election`
were deprecated in favor of --metrics-bind-address and --leader-elect to be more
aligned with core Kubernetes Components.

For more info:
kubernetes-sigs/kubebuilder#1839

All cluster api providers have made related changes. It leads to the fact
that when we try to use old flags there, operator returns an error.
Fedosin added a commit to Fedosin/cluster-api-operator that referenced this issue Apr 24, 2023
@Fedosin
Use correct flags in component customizer
ee7c2da 
In kubebuilder the manager flags `--metrics-addr` and `enable-leader-election`
were deprecated in favor of --metrics-bind-address and --leader-elect to be more
aligned with core Kubernetes Components.

For more info:
kubernetes-sigs/kubebuilder#1839

All cluster api providers have made related changes. It leads to the fact
that when we try to use old flags there, operator returns an error.
@domcyrus domcyrus mentioned this issue Apr 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christopherhein christopherhein

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚠️ (go/v3-alpha) Align flag names with Kubernetes Components christopherhein/kubebuilder
2 participants
@christopherhein @estroz