-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ (go/v3-alpha) Align flag names with Kubernetes Components #1852
⚠️ (go/v3-alpha) Align flag names with Kubernetes Components #1852
Conversation
/assign @estroz |
20c5b7d
to
8f67fdd
Compare
Because flag names are changing between go/v2 and go/v3, can you retitle this PR with /approve |
Thanks, @estroz updated. |
Signed-off-by: Chris Hein <me@chrishein.com>
Signed-off-by: Chris Hein <me@chrishein.com>
8f67fdd
to
d423bfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christopherhein, estroz, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This aligns the current
v3
flags with other Kubernetes core components for leader election and for metrics address.Fixes #1839