-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add group in the log when is multi-group #1502
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single comment (in two places)
/lgtm |
/lgtm cancel |
Wait, this can only be done for v3 onwards, v2 projects can be changed that way or they will be backwards incompatible. |
HI @Adirio, As we chat about in this case has no breaking change we are just adding the new log. Also, a test was made to ensure it as follows.
It will just add one value more in the scaffold for logs. |
As we spoke in Slack, this is not technically bacwards incompatible, but the behaviour is a bit different. Previously scaffolded controllers won't have the group info while new ones will. I'm ok with this but let's see what @DirectXMan12 and @mengqiy have to say about it. Otherwise, lgtm |
It will be addressed just for V3 in : #1498 |
Closes: #1383