Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add group in the log when is multi-group #1502

Closed
wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Member

Closes: #1383

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from droot and mengqiy May 8, 2020 02:13
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2020
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single comment (in two places)

testdata/project-v2-addon/go.mod Outdated Show resolved Hide resolved
testdata/project-v3-addon/go.mod Outdated Show resolved Hide resolved
@Adirio
Copy link
Contributor

Adirio commented May 13, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2020
@Adirio
Copy link
Contributor

Adirio commented May 13, 2020

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2020
@Adirio
Copy link
Contributor

Adirio commented May 13, 2020

Wait, this can only be done for v3 onwards, v2 projects can be changed that way or they will be backwards incompatible.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented May 13, 2020

HI @Adirio,

As we chat about in this case has no breaking change we are just adding the new log. Also, a test was made to ensure it as follows.

  • Create a project with master
  • Scaffold APIs using multi-group
  • then, use the PR to add new APIs

It will just add one value more in the scaffold for logs.

Screenshot 2020-05-13 at 10 41 40

@Adirio
Copy link
Contributor

Adirio commented May 13, 2020

As we spoke in Slack, this is not technically bacwards incompatible, but the behaviour is a bit different. Previously scaffolded controllers won't have the group info while new ones will. I'm ok with this but let's see what @DirectXMan12 and @mengqiy have to say about it. Otherwise, lgtm

@camilamacedo86
Copy link
Member Author

It will be addressed just for V3 in : #1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V3] Multi-group log context
3 participants