-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: plugin resolution for multi-projects support #1538
fix: plugin resolution for multi-projects support #1538
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @estroz |
43e807c
to
c7f3566
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand what you're doing here, I think these changes are conflating "use the latest plugin version that supports a given project version" with "allow multiple non-default plugins per project version". The latter problem is solved by permitting multiple plugins per project version, then resolving a plugin key to a single plugin or erroring out. See #1536.
HI @estroz,
It will return always the latest plugin version which is supported by the PROJECT version. Example
Then:
And then, if we implement a new version such as I hope that it clarifies. |
Closing this one based in the comment: #1526 (comment) |
@camilamacedo86: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closes: #1526
Note that the problem was faced/found in the #1498. (the error is faced when we gen the testdata which is checked in the CI) In this way, it is easy verified by checking that the same PR is working successfully with this fix applied.