Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin resolution for multi-projects support #1538

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 30, 2020

Closes: #1526

Note that the problem was faced/found in the #1498. (the error is faced when we gen the testdata which is checked in the CI) In this way, it is easy verified by checking that the same PR is working successfully with this fix applied.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2020
@camilamacedo86
Copy link
Member Author

/assign @estroz

Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand what you're doing here, I think these changes are conflating "use the latest plugin version that supports a given project version" with "allow multiple non-default plugins per project version". The latter problem is solved by permitting multiple plugins per project version, then resolving a plugin key to a single plugin or erroring out. See #1536.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jun 1, 2020

HI @estroz,

If I understand what you're doing here, I think these changes are conflating "use the latest plugin version that supports a given project version" with "allow multiple non-default plugins per project version".

It will return always the latest plugin version which is supported by the PROJECT version.

Example
We have:

  • go.kubebuilder.io/v2.0.0 which is supported by V2 and V3
  • go.kubebuilder.io/v3.0.0 which is supported by V3

Then:

  • When I run the KB commands for V2 PROJECT version the upper plugin versions which are supported by V2 projects be used. In this case is: go.kubebuilder.io/v2.0.0
  • When I run the KB commands for V3 PROJECT version the upper plugin version which is supported by V3 projects be used. In this case is: go.kubebuilder.io/v3.0.0

And then, if we implement a new version such as go.kubebuilder.io/v3.1.0 then, it will be the default version returned/used by V3.

I hope that it clarifies.

@camilamacedo86
Copy link
Member Author

Closing this one based in the comment: #1526 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2020
@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86 camilamacedo86 deleted the fix-plugin-resolution branch June 1, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins are not supporting multi-project version
3 participants