*: remove plugin minor/patch versions #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
While this gets reviewed/discussed /hold |
k8s-ci-robot
added
the
do-not-merge/hold
estroz
force-pushed
the
chore/remove-plugin-patch-version
branch
from
c3fb531
to
8fa596c
Compare
k8s-ci-robot
added
size/XL
|
/test pull-kubebuilder-test |
estroz
force-pushed
the
chore/remove-plugin-patch-version
branch
from
8fa596c
to
1b4942a
Compare
|
Ready for review. It looks like there are a bunch of changes here, but most of them are removal of minor+patch version from comments/strings and centralizing plugin-related code where appropriate. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -36,12 +36,13 @@ func TestCLI(t *testing.T) { | |||
|
|
|||
| // Test plugin types and constructors. | |||
| type mockPlugin struct { | |||
| name, version string | |||
| name string | |||
| version plugin.Version | |||
| projectVersions []string | |||
There was a problem hiding this comment.
I think it is now beyond what we need. but I am ok with 👍
estroz
changed the title
estroz
force-pushed
the
chore/remove-plugin-patch-version
branch
from
1b4942a
to
e689089
Compare
estroz
force-pushed
the
chore/remove-plugin-patch-version
branch
from
e689089
to
7186525
Compare
…refix and stability "alpha" or "beta" suffix, ex. "v2-alpha". Minor and patch version changes are poorly defined and may constitute breaking changes; having a single version number makes versioning simpler and permits breaking changes to be grouped into one "major" release for a plugin. *: remove references to minor and patch versions for plugins pkg/plugin: implement a Version type returned by Base.Version() that is easily parsed and validated pkg/cli: simplify plugin resolver given the minor/patch number drop
estroz
force-pushed
the
chore/remove-plugin-patch-version
branch
from
7186525
to
4f890fc
Compare
camilamacedo86
approved these changes
Jun 4, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin versions are now considered single numbers with optional "v" prefix and stability "alpha" or "beta" suffix, ex. "v2-alpha". Minor and patch version changes are poorly defined and may constitute breaking changes; having a single version number makes versioning simpler and permits breaking changes to be grouped into one "major" release for a plugin. See #1519 for more details.
Versiontype returned byBase.Version()that is easily parsed and validatedNote: This change will affect project configs with
layout: go.kubebuilder.io/v2.0.0, but because this value was not scaffolded by a released version of kubebuilder we shouldn't have to migrate anyone./cc @DirectXMan12 @joelanford @camilamacedo86