internal/plugins: remove minor/patch version, add "-alpha" #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin.Version type, which only contains a "major" version integer and an optional stage string. *: remove references to minor and patch versions for plugins, add "alpha" stage
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Hi @estroz, i think it is great to go now and we can do follow-ups if/when we need too. |
|
One more set of eyes then I'll merge. |
estroz
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
*: remove references to minor and patch versions for plugins, add "alpha" stage
Motivation for the change: Plugin versions have been removed and replaced with kubebuilder's plugin.Version type, which only contains a "major" version integer and an optional stage string. The "alpha" suffix is to denote that this plugin version might change soon. We can remove this when the plugin is stable.
This is a follow-up from kubernetes-sigs/kubebuilder#1547.