pkg: refactor scaffolds and machinery under plugins #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
estroz
force-pushed
the
chore/refactor-plugins-scaffolds
branch
from
932c1d6
to
cd0c142
Compare
|
/test pull-kubebuilder-e2e-k8s-1-16-2 |
that machinery directly and only relates to plugins. Scaffold templates are also versioned with plugin major version, ex. pkg/plugin/v2.
estroz
force-pushed
the
chore/refactor-plugins-scaffolds
branch
from
cd0c142
to
6fde51d
Compare
Comment on lines
+27
to
+28
| "sigs.k8s.io/kubebuilder/pkg/plugin/scaffold" | ||
| scaffolds "sigs.k8s.io/kubebuilder/pkg/plugin/v2/scaffolds" |
There was a problem hiding this comment.
can be in the v3 follow up 👍
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All scaffold templates and machinery are housed under
pkg/pluginsince that machinery directly and only relates to plugins. Scaffold templates are also versioned with plugin major version, ex.pkg/plugin/v2.Changes:
pkg/scaffold/internal/{filesystem,machinery} -> pkg/plugin/internalpkg/scaffold/interface.go -> pkg/plugin/scaffoldpkg/scaffold -> pkg/plugin/v2/scaffoldspkg/plugin/internal/*.go -> pkg/plugin/util/cc @camilamacedo86 @joelanford @DirectXMan12