internal/plugins: move go/v2-alpha to its own package
#3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
needs-rebase
estroz
force-pushed
the
refactor/add-plugin-v2
branch
from
aa27f3d
to
2d84134
Compare
openshift-ci-robot
removed
the
needs-rebase
estroz
force-pushed
the
refactor/add-plugin-v2
branch
from
2d84134
to
497fa04
Compare
cmd/operator-sdk/cli: update import path for Go plugin go.mod,go.sum: bump kubebuilder version
estroz
force-pushed
the
refactor/add-plugin-v2
branch
from
497fa04
to
1df497f
Compare
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package golang | |||
| package v2 | |||
There was a problem hiding this comment.
Can we keep golang and add v2?
See that we will have helm and ansible as well so the golang name make clear.
There was a problem hiding this comment.
The package path contains golang.
estroz
changed the title
go/v2-alpha to its own package.go/v2-alpha to its own package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: the
go.operator-sdk.io/v2-alphaplugin is now in its own package. See kubernetes-sigs/kubebuilder#1550 for a reference as to why this was done./cc @camilamacedo86 @hasbro17 @joelanford