pkg/cli/init.go: make flag help consistent #1564
Conversation
k8s-ci-robot
added
cncf-cla: yes
dupliate plugin keys from flag help
estroz
changed the title
|
/test pull-kubebuilder-e2e-k8s-1-17-0 |
| for _, versionedPlugins := range c.pluginsFromOptions { | ||
| for _, p := range versionedPlugins { | ||
| // Only return non-deprecated plugins. | ||
| if _, isDeprecated := p.(plugin.Deprecated); !isDeprecated { | ||
| pluginKeys = append(pluginKeys, strconv.Quote(plugin.KeyFor(p))) | ||
| keySet[plugin.KeyFor(p)] = struct{}{} |
There was a problem hiding this comment.
I can see that we're doing sort.Strings(pluginKeys) which orders the plugin keys but any reason for building the keySet here and then appending the keys to pluginKeys?
pluginKeys = append(pluginKeys, strconv.Quote(plugin.KeyFor(p))) isn't too unreadable imo.
There was a problem hiding this comment.
c.pluginsFromOptions are indexed by project version, so two versionedPlugins slices can be intersecting sets if one plugin supports two project versions (go/v2 supports project versions 2 and 3-alpha).
|
/test pull-kubebuilder-e2e-k8s-1-15-3 |
|
/test pull-kubebuilder-e2e-k8s-1-14-1 |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubebuilder-e2e-k8s-1-14-1 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Any flag help printed should be consistent between invocations so generated CLI docs (cobra has a nice API for this) don't break randomly. Also remove duplicate plugin keys from flag help.
/cc @camilamacedo86 @DirectXMan12