Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGELOG fragments for new CLI #3254

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

hasbro17
Copy link
Contributor

Description of the change:
Add CHANGELOG fragments to document the changes for:

  • removal of --type=go from operator-sdk new cmd.
  • deprecation of the old CLI
  • addition of the new CLI

Motivation for the change:
Follow up to #3190

@hasbro17 hasbro17 added the kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form label Jun 17, 2020
@hasbro17 hasbro17 force-pushed the changelog-for-new-cli branch 2 times, most recently from 76e48fd to 19becf3 Compare June 17, 2020 23:21
@hasbro17
Copy link
Contributor Author

hasbro17 commented Jun 17, 2020

Most likely waiting on #3255 to fix the sanity check for the CLI reference on master.

@hasbro17
Copy link
Contributor Author

CI failure is for the --project-version args getting a different order every time because Go's iteration order for map keys are not the same every time.

The iteration order over maps is not specified and is not guaranteed to be the same from one iteration to the next.
diff --git a/website/content/en/docs/new-cli/operator-sdk_init.md b/website/content/en/docs/new-cli/operator-sdk_init.md
index aa850bc..b1573be 100644
--- a/website/content/en/docs/new-cli/operator-sdk_init.md
+++ b/website/content/en/docs/new-cli/operator-sdk_init.md
@@ -43,7 +43,7 @@ operator-sdk init [flags]
       --license string           license to use to boilerplate, may be one of 'apache2', 'none' (default "apache2")
       --owner string             owner to add to the copyright
       --plugins strings          Name and optionally version of the plugin to initialize the project with. Available plugins: ("go.kubebuilder.io/v2", "go.kubebuilder.io/v2")
-      --project-version string   project version, possible values: ("2", "3-alpha") (default "3-alpha")
+      --project-version string   project version, possible values: ("3-alpha", "2") (default "3-alpha")

I can restart the CI enough times to get this in though until kubernetes-sigs/kubebuilder#1564 fixes it.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@hasbro17
Copy link
Contributor Author

Merging this.
@joelanford We can do a follow up if you think we need to rephrase anything.

@hasbro17 hasbro17 merged commit abd8a6c into operator-framework:master Jun 18, 2020
@hasbro17 hasbro17 deleted the changelog-for-new-cli branch June 18, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kubebuilder-integration Relates to rewriting the SDK in Kubebuilder plugin form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants