-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ignore #1600
WIP: ignore #1600
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @DirectXMan12 |
5a47726
to
c628545
Compare
/test pull-kubebuilder-e2e-k8s-1-17-0 |
c628545
to
ecf9fac
Compare
3b7a8bc
to
43bbaa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it is sufficient to have this script in this or the controller-runtime repo and add something like the following to docs:
$ curl -sSLo install-envtest-bins.sh https://raw.githubusercontent.com/kubernetes-sigs/kubebuilder/master/scripts/install-envtest-bins.sh
$ chmod +x install-envtest-bins.sh
$ ./install-envtest-bins.sh
This comment has been minimized.
This comment has been minimized.
/lgtm |
/hold |
3773423
to
f331023
Compare
f331023
to
e36c575
Compare
/hold cancel |
/hold |
e36c575
to
e5dade1
Compare
/test pull-kubebuilder-test |
/test pull-kubebuilder-e2e-k8s-1-17-0 |
e5dade1
to
0f9672a
Compare
0f9672a
to
7a83e2f
Compare
7a83e2f
to
3d40d37
Compare
@camilamacedo86: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I am closing this PR since we will change the solution. |
WIP