Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: script call for linux #1610

Merged
merged 1 commit into from
Jul 24, 2020
Merged

fix: script call for linux #1610

merged 1 commit into from
Jul 24, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jul 24, 2020 •
edited
Loading

decription

  • small fix regards issue faced running the script in the Linux
  • add a test to check its execution in both platforms

Related to the PR: #1608

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2020
@camilamacedo86 camilamacedo86 force-pushed the fix-script-linux branch 3 times, most recently from eab5938 to 8f4d436 Compare July 24, 2020 02:33
@camilamacedo86 camilamacedo86 changed the title wip: fix: script call for linux fix: script call for linux Jul 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2020
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-14-1

camilamacedo86
camilamacedo86 commented Jul 24, 2020
View reviewed changes
.travis.yml
@@ -10,7 +10,7 @@ os:
- osx

go:
- "1.13"
- 1.13.x
Copy link
Member Author

@camilamacedo86 camilamacedo86 Jul 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To run the script on Mac OS X we need 1.13.4 or greater

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-15-3

/test pull-kubebuilder-e2e-k8s-1-17-0

djzager
djzager reviewed Jul 24, 2020
View reviewed changes
test.sh
@@ -152,4 +152,7 @@ GO111MODULE=on test_project project-v3 3-alpha
GO111MODULE=on test_project project-v3-multigroup 3-alpha
GO111MODULE=on test_project project-v3-addon 3-alpha

# test script that setup envtest
./scripts/setup_envtest_bins.sh v1.18.2 v3.4.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm struggling to understand why we are installing the envtest binaries right before exiting the test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just for we ensure that the scripts are working in both platform.
The idea is to remove it in the follow-up #1600 where they will be called for each testadata sample via the makefile target instead.

@djzager
Copy link

djzager commented Jul 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit ad31c6c into kubernetes-sigs:master Jul 24, 2020
@camilamacedo86 camilamacedo86 deleted the fix-script-linux branch July 24, 2020 17:37
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@djzager djzager

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @djzager