-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: script call for linux #1610
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ os: | |
- osx | ||
|
||
go: | ||
- "1.13" | ||
- 1.13.x | ||
|
||
git: | ||
depth: 3 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,4 +152,7 @@ GO111MODULE=on test_project project-v3 3-alpha | |
GO111MODULE=on test_project project-v3-multigroup 3-alpha | ||
GO111MODULE=on test_project project-v3-addon 3-alpha | ||
|
||
# test script that setup envtest | ||
./scripts/setup_envtest_bins.sh v1.18.2 v3.4.3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm struggling to understand why we are installing the envtest binaries right before exiting the test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It just for we ensure that the scripts are working in both platform. |
||
|
||
exit $rc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To run the script on Mac OS X we need 1.13.4 or greater