🐛 Add validation for the main.go file present in root directory #1726
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @prafull01. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/cc @camilamacedo86 |
k8s-ci-robot
added
ok-to-test
|
/cc @gabbifish |
pkg/plugin/v2/api.go
Outdated
| @@ -131,6 +134,11 @@ func (p *createAPIPlugin) Validate() error { | |||
| return err | |||
| } | |||
|
|
|||
| // check if main.go is present in the root directory | |||
| if _, err := os.Stat(DefaultMainPath); os.IsNotExist(err) { | |||
There was a problem hiding this comment.
Will doing this break the current workflow that allows kubebuilder create api to create all necessary files even though it returns an error?
There was a problem hiding this comment.
It would be a bug fix but I agree with you. let's apply it only in v3+ plugin. @prafull01 could you please do this change?
/hold
until add only to v3+
There was a problem hiding this comment.
Thanks for validating my suspicions.
There was a problem hiding this comment.
Done.. Thanks @christopherhein for pointing it out.
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, christopherhein, prafull01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Description of the Change:
Added validation to check if main.go is present in the root directory or not.
Added the change for v2 and v3 as this is a bug fix.
Motivation of the change:
If user moves the main.go file and then tries to create any resources like webhook, the operation is done half way, the webhook gets created but kb errors out when trying to write to main file. This should be early detected and the operation should not be allowed at all.
Fixes: #1719