⚠ pkg/cli overhaul

[Adirio]

Description

pkg/cli: mayor overhaul
pkg/plugin: add Validate and ValidateKey helpers instead of ValidateName. The logic of this helpers was in pkg/cli/plugins.go previously.

Motivation

• Prepare for plugin phase 2: 🌱 [WIP] Proposal for Phase 2 Plugins #1801
• Develop tests for smaller pieces of code to improve coverage and delimit better future errors
• Fixes CLI: it would be helpful to skip PROJECT reads for extra commands #1755

TODO

• Finish tests
• Make commands default to one that errors if no plugin provides it: this way, the cli can still be run for those commands that do not require any plugin like version.

NOTE TO REVIEWERS

Side by side comparisson of pkg/cli/cli.go and pkg/cli/cli_test.go does not provide any value. It will be easier to clone this branch and review the files locally together with the new pkg/cli/options.go and pkg/cli/options_test.go files.

[Adirio]

@estroz and @rashmigottipati this is the cli refactoring I told you about some days ago

[Adirio]

/retest

[Adirio]

@estroz @camilamacedo86 @DirectXMan12 This PR should be ready now.

Coverage is reporting a 0.4% global reduction. However, the main files invoved have been extensively tested:

• options.go: 100% of statements covered.
• cli.go: 94.6% of statements covered. The only statements that are not covered are direct file system interactions (parsing the values from the read file is covered, but reading the file is not covered as there is no file to read) (6 lines) and the lines that require to execute the command in order to be covered (6 lines).

[jmrodri]

@Adirio

With this patch applied it works:

$ mkdir PROJECT
$ /home/jesusr/dev/kubebuilder/bin/kubebuilder version
Version: main.version{KubeBuilderVersion:"v2.3.1-391-gf260cc8e", KubernetesVendor:"unknown", GitCommit:"f260cc8ea59e64b444c4b2cf0a40da2fb61f635e", BuildDate:"2020-11-23T20:09:54Z", GoOs:"linux", GoArch:"amd64"}

[estroz]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Adirio]

@camilamacedo86 @estroz this just needs a lgtm label to be merged

[estroz]

/lgtm

[estroz]

/override coverage/coveralls

[pwittrock]

/override coverage/coveralls

[pwittrock]

Force merging this because the broken check doesn't make sense. Lets follow up with a better fix.