Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ *: stabilize project version 3 #1901

Closed
wants to merge 1 commit into from
Closed

⚠️ *: stabilize project version 3 #1901

wants to merge 1 commit into from

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Dec 12, 2020

This PR stabilizes project version 3-alpha as 3.

P.S.: there are a few PRs open that change project structure significantly (#1869, #1899). We may want to forego those changes until project version 4 given the impending v3.0.0 release and stability concerns, or not. Whatever the case, this PR can block until the community feels ready to stabilize.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2020
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2020
@Adirio
Copy link
Contributor

Adirio commented Dec 12, 2020

You mentioned that having 3-alpha supported by go/v2 would help transitioning from go/v2 to go/v3, should we just leave 3-alpha and just create a new 3 project version?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2020
@estroz estroz mentioned this pull request Jan 18, 2021
Closed
@estroz estroz force-pushed the feature/stabilize-project-3-alpha branch from 450b417 to adddb9a Compare January 18, 2021 20:42
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2021
@estroz
Copy link
Contributor Author

estroz commented Jan 18, 2021

should we just leave 3-alpha and just create a new 3 project version?

This is kinda ugly. For how long would we support 3-alpha? How do we tell users to upgrade? I'd rather have a policy of getting rid of alpha/beta versions as soon as the next most stable version is available, and relying on this error message to inform users of an upgrade.

@camilamacedo86 this relates to your comment.

@Adirio
Copy link
Contributor

Adirio commented Jan 18, 2021

I feel like having go/v2 supporting config v3 will stop us from improving config v3. So I would either leave config 3-alpha as a transition step (at least for some time) or remove go/v2 support for config v3.

@estroz estroz marked this pull request as ready for review January 19, 2021 13:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

@estroz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-test adddb9a link /test pull-kubebuilder-test
pull-kubebuilder-e2e-k8s-1-17-0 adddb9a link /test pull-kubebuilder-e2e-k8s-1-17-0
pull-kubebuilder-e2e-k8s-1-16-2 adddb9a link /test pull-kubebuilder-e2e-k8s-1-16-2
pull-kubebuilder-e2e-k8s-1-18-0 adddb9a link /test pull-kubebuilder-e2e-k8s-1-18-0
pull-kubebuilder-e2e-k8s-1-15-3 adddb9a link /test pull-kubebuilder-e2e-k8s-1-15-3
pull-kubebuilder-e2e-k8s-1-14-1 adddb9a link /test pull-kubebuilder-e2e-k8s-1-14-1
pull-kubebuilder-e2e-k8s-1-15-12 adddb9a link /test pull-kubebuilder-e2e-k8s-1-15-12
pull-kubebuilder-e2e-k8s-1-16-15 adddb9a link /test pull-kubebuilder-e2e-k8s-1-16-15
pull-kubebuilder-e2e-k8s-1-14-10 adddb9a link /test pull-kubebuilder-e2e-k8s-1-14-10

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@estroz
Copy link
Contributor Author

estroz commented Jan 20, 2021

Closing in favor of #1959

@estroz estroz closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@estroz @k8s-ci-robot @Adirio @camilamacedo86