-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ make project version == 3 instead of 3-alpha #1959
⚠️ make project version == 3 instead of 3-alpha #1959
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubebuilder-test |
984acfb
to
e6d0b18
Compare
This is a duplicate of #1901 |
e6d0b18
to
3f67ffc
Compare
3f67ffc
to
40ce45b
Compare
HI @estroz,
The #1901 is a draft pr which shows that needs to be rebased with master and still missing places to be updated/changed. Also, see that its first comment is outdated as well. However, this PR is done to get merge and is passing in the CI and etc. So, IMO we can close the draft one and get it's merged for we are able to achieve the goal as soon as possible. WDYT? |
/hold cancel |
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@camilamacedo86: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Close in favor of : #1968 |
Description
Motivation