Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ make project version == 3 instead of 3-alpha #1959

Closed
wants to merge 1 commit into from
Closed

⚠️ make project version == 3 instead of 3-alpha #1959

wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Member

Description

  • make project version == 3 instead of 3-alpha

Motivation

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2021
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-test

@estroz
Copy link
Contributor

estroz commented Jan 18, 2021

This is a duplicate of #1901

@camilamacedo86 camilamacedo86 changed the title ⚠️ make project version == 3 instead of 3-alpha WIP: ⚠️ make project version == 3 instead of 3-alpha Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 18, 2021
@camilamacedo86 camilamacedo86 changed the title WIP: ⚠️ make project version == 3 instead of 3-alpha ⚠️ make project version == 3 instead of 3-alpha Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2021
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jan 19, 2021 •
edited

HI @estroz,

This is a duplicate of #1901

The #1901 is a draft pr which shows that needs to be rebased with master and still missing places to be updated/changed. Also, see that its first comment is outdated as well. However, this PR is done to get merge and is passing in the CI and etc. So, IMO we can close the draft one and get it's merged for we are able to achieve the goal as soon as possible.

WDYT?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@camilamacedo86
Copy link
Member Author

/hold cancel

@estroz estroz mentioned this pull request Jan 20, 2021
Closed
@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-e2e-k8s-1-15-12 40ce45b link /test pull-kubebuilder-e2e-k8s-1-15-12

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2021
@Adirio Adirio mentioned this pull request Jan 26, 2021
Merged
@camilamacedo86
Copy link
Member Author

Close in favor of : #1968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirio Adirio Awaiting requested review from Adirio

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make project version == 3 instead of 3-alpha (only for the stable release)
3 participants
@camilamacedo86 @k8s-ci-robot @estroz