Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add the rest of the missing fields and stabilize config v3 #1968

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Jan 22, 2021

Create the v3 config implementation that includes all missing fields.

Closes: #1772
Closes: #1826
Closes: #1959

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 26, 2021
@Adirio Adirio force-pushed the config/v3 branch 2 times, most recently from 1c54080 to 9797cf5 Compare January 26, 2021 12:40
@Adirio Adirio marked this pull request as ready for review January 26, 2021 12:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows great for me 🥇
I added just a few nits.

@estroz wdyt?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
Signed-off-by: Adrian Orive Oneca <adrian.orive.oneca@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86, irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christopherhein
Copy link
Member

Nice work, this lgtm!

@camilamacedo86
Copy link
Member

This PR has been addressing the changes in the PROJECT file which has been discussed for a while and that we reach a consensus. Also, I have been adding this PR for all week in the Slack channel to see if someone has some objection. It has 3 oks already then, it shows good enough to get merged:

/lgtm

PS.:See that the PR #1869 adds the same fields and also was approved by @estroz as well in the past. The reason for the old pr not get merged was the discussions regards the model changes which now are addressed properly via the PR; #1911.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 71b8578 into kubernetes-sigs:master Jan 29, 2021
@Adirio Adirio deleted the config/v3 branch January 29, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project file with all user input data [Discussion] V3 breaking changes
5 participants