Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix the bug where an error was being hidden by a potentially valid flag not being recognized by the root command #2023

Merged
merged 1 commit into from
Feb 17, 2021
Merged

🐛 Fix the bug where an error was being hidden by a potentially valid flag not being recognized by the root command #2023

merged 1 commit into from
Feb 17, 2021

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Feb 17, 2021

By telling the root command that it should not error out if found unknown flags we ensure that the error that made us print the root help message is surfaced instead of being hidden behind the unknown flag: --flag bug.

Fixes: #2022

@Adirio
Fix the bug where an error was being hidden by a potentially valid fl…
e23cbe4 
…ag not being recognized by the root command

Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2021
camilamacedo86
camilamacedo86 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Adirio,camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b46beea into kubernetes-sigs:master Feb 17, 2021
@Adirio Adirio deleted the fix-hidden-error branch February 17, 2021 11:53
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Actual error hidden behind unknown flag error
3 participants
@Adirio @k8s-ci-robot @camilamacedo86