Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix the bug where an error was being hidden by a potentially valid flag not being recognized by the root command #2023

Merged
merged 1 commit into from
Feb 17, 2021
Merged

🐛 Fix the bug where an error was being hidden by a potentially valid flag not being recognized by the root command #2023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/cli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ func (c cli) newRootCmd() *cobra.Command {
fs.String(projectVersionFlag, "", "project version")
fs.StringSlice(pluginsFlag, nil, "plugin keys of the plugin to initialize the project with")

// As the root command will be used to shot the help message under some error conditions,
// like during plugin resolving, we need to allow unknown flags to prevent parsing errors.
cmd.FParseErrWhitelist = cobra.FParseErrWhitelist{UnknownFlags: true}

return cmd
}

Expand Down