-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (go/v3) Makefile: set SHELL to the system's bash
binary with shell opts
#2149
✨ (go/v3) Makefile: set SHELL to the system's bash
binary with shell opts
#2149
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
and set shell options pipefail and errexit. setup-envtest.sh needs bash, so the Makefile should provide best-effort support to find and use it. Docs were updated to include manual install instructions for envtest binaries, in case setup-envtest.sh cannot be used to download binaries. Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
3aa1038
to
c23f90a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
(go/v3) set the Makefile's SHELL variable to the system's bash binary, and set shell options pipefail and errexit. setup-envtest.sh needs bash, so the Makefile should provide best-effort support to find and use it. Docs were updated to include manual install instructions for envtest binaries, in case setup-envtest.sh cannot be used to download binaries.
There have been a few attempts to ameliorate setup-envtest.sh breakage on systems with a different shell as the
/bin/sh
(#1711, #1725, #1864). These have all been closed, so the problem persists./kind bug
Closes #2121
Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com