Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (go/v3) Makefile: set SHELL to the system's bash binary with shell opts #2149

Merged
merged 1 commit into from
Apr 20, 2021

Commits on Apr 20, 2021

  1. (go/v3) set the Makefile's SHELL variable to the system's bash binary,

    and set shell options pipefail and errexit. setup-envtest.sh needs
    bash, so the Makefile should provide best-effort support
    to find and use it. Docs were updated to include manual install
    instructions for envtest binaries, in case setup-envtest.sh
    cannot be used to download binaries.
    
    Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
    estroz committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c23f90a View commit details
    Browse the repository at this point in the history