🌱 update release-3 for v3.0.0 #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix markdown format error in VERSIONING.md about ref to tools-branch link.
Validation appears to have increased slightly, and some deprecated fields were switch up. This made it impossible to file issues in KubeBuilder, which is... suboptimal. This fixes that, so we can once again open the receive bugs :-)
🌱 Fix issue templates
Previous documentation erroneously misconfigured the cronjob's tutorial to use the manager's client everywhere, which is poor practice because using a cache client in assertions leads to flaky & slow tests. A new PR overcorrected, and switched both assertions *and* the reconciler to use a live client, which is also wrong, because the reconciler needs to use a manager's client to function properly. This corrects the documentation to indicate that reconcilers should use managers' clients, and test assertions should use a live client, and adds a full explanation as to why.
This makes sure that the cronjob's tutorial's tests are run in make test, which should avoid breaking the book again.
The CI previously duplicated the contents of `make test` in a separate script. This just makes that script call `make test` instead.
📖 Fix advice on clients in tests, ensure that book gets tested
📖 Fix markdown format in VERSIONING.md
📖 update the docs over regards book-v3 branch
|
@estroz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the local branch
masterintorelease-3in preparation forv3.0.0./kind release