-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 update release-3 for v3.0.0 #2163
Conversation
This commit fix markdown format error in VERSIONING.md about ref to tools-branch link.
Validation appears to have increased slightly, and some deprecated fields were switch up. This made it impossible to file issues in KubeBuilder, which is... suboptimal. This fixes that, so we can once again open the receive bugs :-)
🌱 Fix issue templates
Previous documentation erroneously misconfigured the cronjob's tutorial to use the manager's client everywhere, which is poor practice because using a cache client in assertions leads to flaky & slow tests. A new PR overcorrected, and switched both assertions *and* the reconciler to use a live client, which is also wrong, because the reconciler needs to use a manager's client to function properly. This corrects the documentation to indicate that reconcilers should use managers' clients, and test assertions should use a live client, and adds a full explanation as to why.
This makes sure that the cronjob's tutorial's tests are run in make test, which should avoid breaking the book again.
The CI previously duplicated the contents of `make test` in a separate script. This just makes that script call `make test` instead.
📖 Fix advice on clients in tests, ensure that book gets tested
📖 Fix markdown format in VERSIONING.md
📖 update the docs over regards book-v3 branch
@estroz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR merges the local branch
master
intorelease-3
in preparation forv3.0.0
./kind release