⚠️ update deps to use k8s 1.22 #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
2 tasks
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
update-controller-runtime
branch
from
4461e43
to
2f1588d
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
update-controller-runtime
branch
4 times, most recently
from
349edb5
to
8d56b6f
Compare
k8s-ci-robot
added
size/XXL
camilamacedo86
force-pushed
the
update-controller-runtime
branch
6 times, most recently
from
017e13c
to
a8d3be0
Compare
|
/test pull-kubebuilder-e2e-k8s-1-16-15 |
camilamacedo86
force-pushed
the
update-controller-runtime
branch
from
a8d3be0
to
c85d992
Compare
camilamacedo86
force-pushed
the
update-controller-runtime
branch
2 times, most recently
from
70b163d
to
bc93841
Compare
camilamacedo86
changed the title
k8s-ci-robot
added
do-not-merge/hold
camilamacedo86
force-pushed
the
update-controller-runtime
branch
2 times, most recently
from
13e7d5f
to
6766994
Compare
camilamacedo86
removed
the
do-not-merge/hold
Description Update deps to use k8s 1.22 Update controller-tools to 0.7.0 Update sigs.k8s.io/controller-runtime to 0.10.0 Update ENV TEST to 1.22
camilamacedo86
force-pushed
the
update-controller-runtime
branch
from
6766994
to
60803e8
Compare
camilamacedo86
changed the title
| // todo: it should be removed for go/v4 | ||
| // nolint:lll,gosec | ||
| if p.resource.API.CRDVersion == "v1beta1" { | ||
| if err := applyScaffoldCustomizationsForVbeta1(); err != nil { |
There was a problem hiding this comment.
would we still be supporting this in go/v3 ? Since we are scaffolding the project with k8s 1.22, should we be removing support for v1beta1 APIs completely ?
There was a problem hiding this comment.
To ensure backwards compatibility:
- If the flags crd-version or webhook-version be informed with v1beta1 the makefile and go.mod are updated, and the user informed
- Marke as deprecates the flags crd-version or webhook-version since we probably will remove it in future versions.
We cannot remove the option for go/v3. That would be a breaking change and we will allow to do that only when we create go/v4.
| sigs.k8s.io/controller-tools v0.6.0 // for `kubebuilder alpha config-gen` | ||
| golang.org/x/tools v0.1.5 | ||
| k8s.io/apimachinery v0.22.2 // for `kubebuilder alpha config-gen` | ||
| sigs.k8s.io/controller-runtime v0.10.0 |
There was a problem hiding this comment.
Not a blocker at all, but since the PR is still open we could do 0.10.1 of controller-runtime too as it has k8s bumped to 1.22.2
There was a problem hiding this comment.
yes. I think we can -)
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I will need to force this PR because of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Golang/v3 only:
To ensure backwards compatibility:
Notes
Closes: #2339