📖 update RELEASE doc to provide the info about how the releases are done #2662
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
camilamacedo86
force-pushed
the
update-release
branch
from
ac73eb3
to
63d1899
Compare
|
/test pull-kubebuilder-e2e-k8s-1-19-4 |
camilamacedo86
force-pushed
the
update-release
branch
from
6952338
to
4f94a3c
Compare
Co-authored-by: Rashmi Gottipati <rgottipa@redhat.com>
camilamacedo86
force-pushed
the
update-release
branch
from
4f94a3c
to
9927f38
Compare
| The build is made from the branch [tools-releases](https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases) and the trigger will call the `build/cloudbuild_tools.yaml` passing | ||
| as argument the architecture and the SO that should be used, e.g: | ||
|
|
||
| <img width="553" alt="Screenshot 2022-04-30 at 10 15 41" src="https://user-images.githubusercontent.com/7708031/166099666-ae9cd2df-73fe-47f6-a987-464f63df9a19.png"> |
There was a problem hiding this comment.
Should this screenshot-png be part of the PR? I am not sure how images are handled in the docs. But could not find any existing references.
There was a problem hiding this comment.
If we click on the view, we can check that. This doc is not used in the books.
So that is fine. I mean, it works fine see:
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| ``` | ||
|
|
||
| However, the image should still be built and maintained since other projects under the org might be using them. |
There was a problem hiding this comment.
Does this step need to be done for every Kubebuilder release?
I didn't see any steps for the proper way to build and verify that the pr-verifier images are built and in the right place. Is this an automated process that only occurs when changes are made to the pr-verifier?
There was a problem hiding this comment.
No. This step does need to be done for every KB release. This trigger is done for the repo: kubernetes-sigs/kubebuilder-release-tools and not in the Kubebuilder repo. This image is only used in the Kuebuilder CI to check the PR title and descriptions. We just need to re-gen new images when we have updates/changes there.
There was a problem hiding this comment.
Since that is a separate repo, should release steps for that image be provided in that repo instead of the KB release steps?
How does this relate to a KB release other than that the pr-verifier action is used to verify KB PRs?
There was a problem hiding this comment.
Becuase it is maintained by us.
See that it is kubebuilder-tools-release and is under Kubebuilder project when we check the Google cloud triggers. So, I just want to make clear the info.
Any extra information should be checked in its repo. We can improve it afterwords. For now, my goal is we have the info at least in case someone need to check it out.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubebuilder-e2e-k8s-1-14-10 |
Description
update RELEASE doc to provide the info about how the releases are done
Closes: #2580