Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 clean up samples by removing deprecated options #2741

Merged
merged 1 commit into from
Jun 17, 2022
Merged

🌱 clean up samples by removing deprecated options #2741

merged 1 commit into from
Jun 17, 2022

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jun 16, 2022 •
edited
Loading

Description

  • remove samples with add-on and declarative for project-v2
  • remove samples for v1beta1 CRDs and WebHooks

Motivation

  • We are adding new plugins and options so that we will have more samples
  • The project-v2 samples uses go/v2 which can no longer be updated and exist only for backwards compatibility with the legacy layout. Projects with it cannot work on Kubernetes 1.22+ so that seems we can clean up here since we also do not encourage people to use them.
  • Also, we do not encourage users still using v1beta1 CRDs and this option is deprecated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2022
@camilamacedo86 camilamacedo86 added this to the 3.5.0 milestone Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2022
@camilamacedo86 camilamacedo86 changed the title 🌱 remove samples with add-on and declarative for project-v2 🌱 clean up samples by removing deprecated options Jun 16, 2022
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-18-20

everettraven
everettraven reviewed Jun 17, 2022
View reviewed changes
test/testdata/generate.sh
@@ -123,12 +119,9 @@ build_kb

# Project version 2 uses plugin go/v2 (default).
scaffold_test_project project-v2 --project-version=2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this one as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think so.
Why? we need to ensure in the reviews that changes are not made in this scaffold.
By keeping it, we can easily check that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

everettraven
everettraven reviewed Jun 17, 2022
View reviewed changes
test/testdata/generate.sh
# Project version 3 (default) uses plugin go/v3 (default).
scaffold_test_project project-v3
scaffold_test_project project-v3-multigroup
scaffold_test_project project-v3-addon --plugins="go/v3,declarative"
scaffold_test_project project-v3-config --component-config
scaffold_test_project project-v3-v1beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing the v2 projects since they are being deprecated, but are we also deprecating the v1beta1 support for the go/v3 plugin? If not then I think we should keep this one in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @everettraven.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do not want anybody using v1neta1. It does not work since K8s >= 1.22 and the flag is deprecated across all places

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, then this is good.

everettraven
everettraven reviewed Jun 17, 2022
View reviewed changes
test/testdata/test_legacy.sh
@@ -34,5 +34,4 @@ build_kb
tools_k8s_version="1.19.2"
fetch_tools
test_project project-v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this one as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nops, since we will keep the sample

everettraven
everettraven approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2022
rashmigottipati
rashmigottipati approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

🌱 clean up samples by removing deprecated options
5397fba 
- remove samples with add-on and declarative for project-v2
- remove samples for v1beta1 CRDs and WebHooks
- no longer using this extra options on the legacy tests

:seedling: remove samples with add-on and declarative for project-v2
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2022
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 44718e7 into kubernetes-sigs:master Jun 17, 2022
@camilamacedo86 camilamacedo86 deleted the reduce-testdata-samples branch June 17, 2022 16:36
@everettraven everettraven mentioned this pull request Jun 24, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@everettraven everettraven everettraven approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@rashmigottipati rashmigottipati

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camilamacedo86 @k8s-ci-robot @rashmigottipati @everettraven