-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 clean up samples by removing deprecated options #2741
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,10 +107,6 @@ function scaffold_test_project { | |
$kb create api --group crew --version v1 --kind Captain --controller=true --resource=true --make=false | ||
$kb create api --group crew --version v1 --kind FirstMate --controller=true --resource=true --make=false | ||
$kb create api --group crew --version v1 --kind Admiral --controller=true --resource=true --namespaced=false --make=false | ||
elif [[ $project =~ v1beta1 ]]; then | ||
header_text 'Creating APIs ...' | ||
$kb create api --group crew --version v1 --kind Admiral --controller=true --resource=true --namespaced=false --make=false --crd-version=v1beta1 | ||
$kb create webhook --group crew --version v1 --kind Admiral --defaulting --webhook-version=v1beta1 | ||
fi | ||
|
||
make generate manifests | ||
|
@@ -123,12 +119,9 @@ build_kb | |
|
||
# Project version 2 uses plugin go/v2 (default). | ||
scaffold_test_project project-v2 --project-version=2 | ||
scaffold_test_project project-v2-multigroup --project-version=2 | ||
scaffold_test_project project-v2-addon --project-version=3 --plugins="go/v2,declarative" | ||
# Project version 3 (default) uses plugin go/v3 (default). | ||
scaffold_test_project project-v3 | ||
scaffold_test_project project-v3-multigroup | ||
scaffold_test_project project-v3-addon --plugins="go/v3,declarative" | ||
scaffold_test_project project-v3-config --component-config | ||
scaffold_test_project project-v3-v1beta1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with removing the v2 projects since they are being deprecated, but are we also deprecating the v1beta1 support for the go/v3 plugin? If not then I think we should keep this one in. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with @everettraven. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we do not want anybody using v1neta1. It does not work since K8s >= 1.22 and the flag is deprecated across all places There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gotcha, then this is good. |
||
scaffold_test_project project-v3-with-kustomize-v2 --plugins="kustomize/v2-alpha,base.go.kubebuilder.io/v3" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,5 +34,4 @@ build_kb | |
tools_k8s_version="1.19.2" | ||
fetch_tools | ||
test_project project-v2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we remove this one as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nops, since we will keep the sample |
||
test_project project-v2-multigroup | ||
test_project project-v2-addon | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this one as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think so.
Why? we need to ensure in the reviews that changes are not made in this scaffold.
By keeping it, we can easily check that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense