Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Thank you for the contribution 🥇
We need to update the whole project accordingly and not only the goreleaser file.
See: #2908
Would you like to start to help out by creating the envtools binaries for 1.25?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c/c @sbueringer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Thank sounds great @camilamacedo86.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 Thx, I overlooked the base branch of this PR.
Just out of curiosity. Does bumping the version on the tools-releases branch depend on kubebuilder itself on main being bumped before?
EDIT: Ah "Would you like to start to help out by creating the envtools binaries for 1.25?" that's actually bumping the tools-release branch, right? And it has to be done first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sbueringer,
We use the envtest in the scaffolds as well see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/Makefile#L5
But updating the goreleases would need to be done when we update the whole project.